Added linux-usb@xxxxxxxxxxxxxxx to recipient list.
Minas
On 7/3/2020 11:55 AM, Minas Harutyunyan wrote:
> Hi,
>
> On 7/3/2020 11:34 AM, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
>>
>> This is a note to let you know that I've just added the patch titled
>>
>> usb: dwc2: gadget: Remove assigned but never used 'maxsize'
>>
>> to my usb git tree which can be found at
>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
>> in the usb-testing branch.
>>
>> The patch will show up in the next release of the linux-next tree
>> (usually sometime within the next 24 hours during the week.)
>>
>> The patch will be merged to the usb-next branch sometime soon,
>> after it passes testing, and the merge window is open.
>>
>> If you have any questions about this process, please let me know.
>>
>>
>
> Greg, I'll prefer if Lee Jones add "Fixes:" tag and resubmit v2.
>
> Thanks,
> Minas
>
>
>> From 7c7cb6cd92807cc226fc82ada053b8035317ab51 Mon Sep 17 00:00:00 2001
>> From: Lee Jones <lee.jones@xxxxxxxxxx>
>> Date: Thu, 2 Jul 2020 15:46:05 +0100
>> Subject: usb: dwc2: gadget: Remove assigned but never used 'maxsize'
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> The value of 'maxsize' has not been checked since commit 729cac693eecf
>> ("usb: dwc2: Change ISOC DDMA flow") back in 2018, so remove the set but
>> unused variable, which fixes the following W=1 kernel build warning:
>>
>> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_fill_isoc_desc’:
>> drivers/usb/dwc2/gadget.c:885:6: warning: variable ‘maxsize’ set but not used [-Wunused-but-set-variable]
>> 885 | u32 maxsize = 0;
>> | ^~~~~~~
>>
>> Cc: Minas Harutyunyan <hminas@xxxxxxxxxxxx>
>> Cc: Ben Dooks <ben@xxxxxxxxxxxx>
>> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>> Link: https://urldefense.com/v3/__https://lore.kernel.org/r/20200702144625.2533530-11-lee.jones@linaro.org__;!!A4F2R9G_pg!IhpSf7ldHd1TxgfEqGeDO5GoDgF26x79lj2HYkRvnVYaEq2TxwllvewSx9kfKtc$
>> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/usb/dwc2/gadget.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
>> index ea7c9c73b4ff..d98c1df91db8 100644
>> --- a/drivers/usb/dwc2/gadget.c
>> +++ b/drivers/usb/dwc2/gadget.c
>> @@ -880,11 +880,10 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep,
>> struct dwc2_dma_desc *desc;
>> struct dwc2_hsotg *hsotg = hs_ep->parent;
>> u32 index;
>> - u32 maxsize = 0;
>> u32 mask = 0;
>> u8 pid = 0;
>>
>> - maxsize = dwc2_gadget_get_desc_params(hs_ep, &mask);
>> + dwc2_gadget_get_desc_params(hs_ep, &mask);
>>
>> index = hs_ep->next_desc;
>> desc = &hs_ep->desc_list[index];
>>
