On Mon, Jun 22, 2020 at 11:09:51AM -0600, James Hilliard wrote: > On Mon, Jun 22, 2020 at 2:53 AM Johan Hovold <johan@xxxxxxxxxx> wrote: > > > > On Tue, Jun 16, 2020 at 04:04:03PM -0600, James Hilliard wrote: > > > This is a UPB(Universal Powerline Bus) PIM(Powerline Interface Module) > > > which allows for controlling multiple UPB compatible devices from > > > Linux using the standard serial interface. > > > > > > Based on vendor application source code there are two different models > > > of USB based PIM devices in addition to a number of RS232 based PIM's. > > > > > > The vendor UPB application source contains the following USB ID's: > > > #define USB_PCS_VENDOR_ID 0x04b4 > > > #define USB_PCS_PIM_PRODUCT_ID 0x5500 > > > > > > #define USB_SAI_VENDOR_ID 0x17dd > > > #define USB_SAI_PIM_PRODUCT_ID 0x5500 > > > > > > The first set of ID's correspond to the PIM variant sold by Powerline > > > Control Systems while the second corresponds to the Simply Automated > > > Incorporated PIM. As the product ID for both of these match the default > > > cypress HID->COM RS232 product ID it assumed that they both use an > > > internal variant of this HID->COM RS232 converter hardware. However > > > as the vendor ID for the Simply Automated variant is different we need > > > to also add it to the cypress_M8 driver so that it is properly > > > detected. > > > > > > Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx> > > > --- > > > Changes v1 -> v2: > > > - Add more detailed commit message. > > > > Now applied, thanks. > > Oh, FYI I think part of the comment got dropped when you amended the > patch > I don't see the defines in the comment here: > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=7527d963dff544b0ddfba4319824c50f2a892aeb > > I think I had to temporarily change my git config with this to make it not drop > the defines: > git config core.commentchar "*" Thanks for catching that! I added a leading tab to prevent those lines from being discarded. Johan
