Hi, Reviewed-by: Pawel Laszczak <pawell@xxxxxxxxxxx> > > >The 'tmode' is ctrl->wIndex, changing it as the real test >mode value for register assignment. > >Cc: <stable@xxxxxxxxxxxxxxx> >Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") >Reviewed-by: Jun Li <jun.li@xxxxxxx> >Signed-off-by: Peter Chen <peter.chen@xxxxxxx> >--- > drivers/usb/cdns3/ep0.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c >index 2465a84e8fee..74a1ff5000ba 100644 >--- a/drivers/usb/cdns3/ep0.c >+++ b/drivers/usb/cdns3/ep0.c >@@ -327,7 +327,8 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev, > if (!set || (tmode & 0xff) != 0) > return -EINVAL; > >- switch (tmode >> 8) { >+ tmode >>= 8; >+ switch (tmode) { For me it's looks the same, but it's ok. > case TEST_J: > case TEST_K: > case TEST_SE0_NAK: >-- >2.17.1