On Mon, Jun 22, 2020 at 04:41:35PM +0000, Mario.Limonciello@xxxxxxxx wrote: > > -----Original Message----- > > From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > > Sent: Monday, June 22, 2020 11:38 AM > > To: Limonciello, Mario > > Cc: Andreas Noever; Michael Jamet; Yehezkel Bernat; linux-usb@xxxxxxxxxxxxxxx; > > linux-kernel@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 0/2] Allow breaking up Thunderbolt/USB4 updates > > > > > > [EXTERNAL EMAIL] > > > > Hi Mario, > > > > On Mon, Jun 22, 2020 at 09:30:33AM -0500, Mario Limonciello wrote: > > > Currently updates to Thunderbolt and USB4 controllers are fully atomic > > > actions. When writing into the non-active NVM nothing gets flushed to > > > the hardware until authenticate is sent. > > > > > > There has been some desire to improve the perceived performance of these > > > updates, particularly for userland that may perform the update upon > > > a performance sensitive time like logging out. > > > > > > So allow userland to flush the image to hardware at runtime, and then > > > allow authenticating the image at another time. > > > > > > For the Dell WD19TB some specific hardware capability exists that allows > > > extending this to automatically complete the update when unplugged. > > > Export that functionality to userspace as well. > > > > > > This patch series is done relative thunderbolt.git/next. > > > > Thanks for the patch series. I wonder if you could base this on top of > > my "retimer NVM upgrade" series here (you are also Cc'd): > > > > https://lore.kernel.org/linux-usb/20200616135617.85752-1- > > mika.westerberg@xxxxxxxxxxxxxxx/ > > > > That series moves some of the common NVM functionality into a separate > > file (nvm.c). > > Sure thing. Do you by chance already have that on a public branch somewhere > that I can easily rebase it? I just pushed "bleeding-edge" branch that you should be able to base your stuff on top: https://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git/log/?h=bleeding-edge It includes a couple of other patches as well (subject to change since they are also under review).