Re: [PATCH] USB: ch9: add "USB_" prefix in front of TEST defines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2020-06-18 at 16:42 +0200, Greg Kroah-Hartman wrote:
> For some reason, the TEST_ defines in the usb/ch9.h files did not have
> the USB_ prefix on it, making it a bit confusing when reading the file,
> as well as not the nicest thing to do in a uapi file.
> 
> So fix that up and add the USB_ prefix on to them, and fix up all
> in-kernel usages.  This included deleting the duplicate copy in the
> net2272.h file.
> 
> Cc: Peter Chen <Peter.Chen@xxxxxxx>
> Cc: Minas Harutyunyan <hminas@xxxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxxxxxx>
> Cc: Michal Simek <michal.simek@xxxxxxxxxx>
> Cc: Mathias Nyman <mathias.nyman@xxxxxxxxx>
> Cc: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> Cc: Bin Liu <b-liu@xxxxxx>
> Cc: Pawel Laszczak <pawell@xxxxxxxxxxx>
> Cc: YueHaibing <yuehaibing@xxxxxxxxxx>
> Cc: Nathan Chancellor <natechancellor@xxxxxxxxx>
> Cc: Jason Yan <yanaijie@xxxxxxxxxx>
> Cc: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
> Cc: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> Cc: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Jules Irenge <jbi.octave@xxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
> Cc: Rob Gill <rrobgill@xxxxxxxxxxxxxx>
> Cc: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/usb/cdns3/ep0.c              |  8 ++++----
>  drivers/usb/chipidea/udc.c           | 10 +++++-----
>  drivers/usb/common/debug.c           | 10 +++++-----
>  drivers/usb/dwc2/debugfs.c           | 20 ++++++++++----------
>  drivers/usb/dwc2/gadget.c            | 10 +++++-----
>  drivers/usb/dwc3/debugfs.c           | 20 ++++++++++----------
>  drivers/usb/dwc3/ep0.c               | 10 +++++-----
>  drivers/usb/dwc3/gadget.c            | 10 +++++-----
>  drivers/usb/gadget/udc/bdc/bdc_ep.c  | 10 +++++-----
>  drivers/usb/gadget/udc/gr_udc.c      |  4 ++--
>  drivers/usb/gadget/udc/mv_udc_core.c |  2 +-
>  drivers/usb/gadget/udc/net2272.c     |  2 +-
>  drivers/usb/gadget/udc/net2272.h     |  5 -----
>  drivers/usb/gadget/udc/udc-xilinx.c  |  4 ++--
>  drivers/usb/host/xhci-hub.c          |  7 ++++---
>  drivers/usb/misc/ehset.c             |  8 ++++----
>  drivers/usb/mtu3/mtu3_gadget_ep0.c   | 16 ++++++++--------
for mtu3,
Acked-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>

Thanks

>  drivers/usb/musb/musb_gadget_ep0.c   | 20 ++++++++------------
>  drivers/usb/musb/musb_virthub.c      | 20 ++++++++++----------
>  include/uapi/linux/usb/ch9.h         | 10 +++++-----
>  20 files changed, 99 insertions(+), 107 deletions(-)





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux