On Sun, Jun 21, 2020 at 12:34:52PM +0200, Jerry wrote: > Greg Kroah-Hartman wrote on 6/21/20 11:55 AM: > > > I read it, but still not sure what exactly was wrong? Yes, I wrapped lines > > > of description to 80 colums and now I noticed that only 75 columns is > > > allowed but I doubt that it is all? > > That is one thing, but also the "This patch..." should not be in a > > changelog, right? Look at the other changes sent to the list for > > examples of how to do this. > Yes, I looked at another messages here and there are a lot of things which I > don't understand. For example two dash -- marker at the end (bellow patch) > with some strange number (2.7.4). I didn't find anything about that in > documentation. That is the git version number, and you can ignore it. > And documentation request diff -up > https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#diff-up > but patches here use another settings because diff -up never give me line > like > index 86638c1..f1b46b5 100644 > before file names but put me file date and time next to filename. So what > version of diff should I use? I have diff (GNU diffutils) 3.7 git creates that, if you use it for creating a diff. If you want to use diff "by hand", you can do that too, I was not objecting to that at all. The only problems I found was in your changelog text, and your email header. > > > > > Signed-off-by: Jaromir Skorpil <Jerry@xxxxxx> > > > > This does not match your From: line :( > > > I supposed that only mail address in From line matter? > > > I understand that real name is mandatory only for Signed-off-by field? > > It has to match the From: line of your email to ensure that this really > > is the same person. > Really? > I looked at another message as you advised and it seems that even YOUR name > often changes? > https://marc.info/?l=linux-usb&m=159257306831535 > https://marc.info/?l=linux-usb&m=159256948030250 Short name vs. "real name" doesn't matter much when sending email text responses, but it does when sending patches, as you are making a legal agreement about that signed-off-by text. So it has to be the same, otherwise I can not take your patch. > Why is a name so important when you can't verify it? Typing the same text > twice doesn't prove anything. In fact my real name can't be written in ascii > because of diacritics marks and I doubt that it will work here correctly if > I use unicode... Please use unicode (well utf-8 if possible), I'm all for that, there is no requirement to use ascii only for your name in patches. I wish more people would do that when needed, as it's only fair to them to be able to properly represent their names and not have to change them somehow. thanks, greg k-h
