On Fri, Jun 19, 2020 at 11:18:31AM +0000, Rob Gill wrote:
> The user tool modinfo is used to get information on kernel modules, including a
> description where it is available.
>
> This patch adds a brief MODULE_DESCRIPTION to the following modules in driver/usb.
>
> isight_firmware
> mxuport
> u_ether
> uas
>
> Signed-off-by: Rob Gill <rrobgill@xxxxxxxxxxxxxx>
> ---
> drivers/usb/gadget/function/u_ether.c | 1 +
> drivers/usb/misc/isight_firmware.c | 1 +
> drivers/usb/serial/mxuport.c | 1 +
> drivers/usb/storage/uas.c | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
> index fbe96ef1a..579ab41c6 100644
> --- a/drivers/usb/gadget/function/u_ether.c
> +++ b/drivers/usb/gadget/function/u_ether.c
> @@ -1180,3 +1180,4 @@ EXPORT_SYMBOL_GPL(gether_disconnect);
>
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("David Brownell");
> +MODULE_DESCRIPTION("Ethernet-over-USB link layer utilities for Gadget stack");
Is this really "utilities", or just the driver itself for a usb ethernet
gadget? I know you took this from the top of the file, but is that
still correct?
> diff --git a/drivers/usb/misc/isight_firmware.c b/drivers/usb/misc/isight_firmware.c
> index 4d30095d6..607c90c22 100644
> --- a/drivers/usb/misc/isight_firmware.c
> +++ b/drivers/usb/misc/isight_firmware.c
> @@ -129,3 +129,4 @@ module_usb_driver(isight_firmware_driver);
>
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Matthew Garrett <mjg@xxxxxxxxxx>");
> +MODULE_DESCRIPTION("USB isight camera firmware");
This isn't the firmware itself, but a driver to load the firmware. So
maybe "USB isight camera firmware loader"?
thanks,
greg k-h
