On Thu, Jun 18, 2020 at 08:28:51PM -0400, Changming Liu wrote: > isusb_write_mem_bulk calls sisusb_send_bulk_msg and > is called by sisusb_write. > Changed their parameters accordingly. Accordingly to what? The subject just says "change", it does not say what any of this was changed to here. > > Also change the local buf[4] of sisusb_write_mem_bulk > to u8. This fixed a potential undefined behavior. Shouldn't this be a separate patch so that I could be backported to older kernels as it would fix a potential issue? When you have "also" in a patch description, it almost always means you should split the patch up into multiple changes. > > Signed-off-by: Changming Liu <liu.changm@xxxxxxxxxxxxxxxx> This email address doesn't match the "From:" line :( thanks, greg k-h
