Re: [PATCH] USB: core: additional Device Classes to debug/usb/devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on balbi-usb/testing/next peter.chen-usb/ci-for-usb-next v5.7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Rob-Gill/USB-core-additional-Device-Classes-to-debug-usb-devices/20200601-175717
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/usb/core/devices.c:140:2: error: expected '}' before '{' token
140 |  {USB_CLASS_WIRELESS_CONTROLLER, "wlcon"},
|  ^
drivers/usb/core/devices.c:121:46: note: to match this '{'
121 | static const struct class_info clas_info[] = {
|                                              ^

vim +140 drivers/usb/core/devices.c

^1da177e4c3f41 Linus Torvalds        2005-04-16  120  
44526f91b887a7 Carlos Sánchez Acosta 2010-04-14  121  static const struct class_info clas_info[] = {
44526f91b887a7 Carlos Sánchez Acosta 2010-04-14  122  	/* max. 5 chars. per name string */
^1da177e4c3f41 Linus Torvalds        2005-04-16  123  	{USB_CLASS_PER_INTERFACE,	">ifc"},
^1da177e4c3f41 Linus Torvalds        2005-04-16  124  	{USB_CLASS_AUDIO,		"audio"},
^1da177e4c3f41 Linus Torvalds        2005-04-16  125  	{USB_CLASS_COMM,		"comm."},
^1da177e4c3f41 Linus Torvalds        2005-04-16  126  	{USB_CLASS_HID,			"HID"},
^1da177e4c3f41 Linus Torvalds        2005-04-16  127  	{USB_CLASS_PHYSICAL,		"PID"},
bf7fbb022f0a3d Frans Pop             2009-06-26  128  	{USB_CLASS_STILL_IMAGE,		"still"},
^1da177e4c3f41 Linus Torvalds        2005-04-16  129  	{USB_CLASS_PRINTER,		"print"},
^1da177e4c3f41 Linus Torvalds        2005-04-16  130  	{USB_CLASS_MASS_STORAGE,	"stor."},
bf7fbb022f0a3d Frans Pop             2009-06-26  131  	{USB_CLASS_HUB,			"hub"},
^1da177e4c3f41 Linus Torvalds        2005-04-16  132  	{USB_CLASS_CDC_DATA,		"data"},
^1da177e4c3f41 Linus Torvalds        2005-04-16  133  	{USB_CLASS_CSCID,		"scard"},
^1da177e4c3f41 Linus Torvalds        2005-04-16  134  	{USB_CLASS_CONTENT_SEC,		"c-sec"},
165fe97ed6107d Craig W. Nadler       2007-06-15  135  	{USB_CLASS_VIDEO,		"video"},
073bfb12268740 Rob Gill              2020-06-01  136  	{USB_CLASS_PERSONAL_HEALTHCARE,	"perhc"},
073bfb12268740 Rob Gill              2020-06-01  137  	{USB_CLASS_AUDIO_VIDEO,		"av"},
073bfb12268740 Rob Gill              2020-06-01  138  	{USB_CLASS_BILLBOARD,		"blbrd"},
073bfb12268740 Rob Gill              2020-06-01  139  	{USB_CLASS_USB_TYPE_C_BRIDGE,	"bridg"}
bf7fbb022f0a3d Frans Pop             2009-06-26 @140  	{USB_CLASS_WIRELESS_CONTROLLER,	"wlcon"},
bf7fbb022f0a3d Frans Pop             2009-06-26  141  	{USB_CLASS_MISC,		"misc"},
bf7fbb022f0a3d Frans Pop             2009-06-26  142  	{USB_CLASS_APP_SPEC,		"app."},
bf7fbb022f0a3d Frans Pop             2009-06-26  143  	{USB_CLASS_VENDOR_SPEC,		"vend."},
^1da177e4c3f41 Linus Torvalds        2005-04-16  144  	{-1,				"unk."}		/* leave as last */
^1da177e4c3f41 Linus Torvalds        2005-04-16  145  };
^1da177e4c3f41 Linus Torvalds        2005-04-16  146  

:::::: The code at line 140 was first introduced by commit
:::::: bf7fbb022f0a3da27a2bcf8d7c973c813d942384 USB: add missing class descriptions used in usb/devices file

:::::: TO: Frans Pop <elendil@xxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux