Re: [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Changming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on balbi-usb/testing/next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Changming/USB-sisusbvga-series-of-changes-char-to-u8/20200601-012438
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/usb/misc/sisusbvga/sisusb.c:2996:11: error: incompatible function pointer types initializing 'ssize_t (*)(struct file *, char *, size_t, loff_t *)' (aka 'long (*)(struct file *, char *, unsigned long, long long *)') with an expression of type 'ssize_t (struct file *, u8 *, size_t, loff_t *)' (aka 'long (struct file *, unsigned char *, unsigned long, long long *)') [-Werror,-Wincompatible-function-pointer-types]
.read =         sisusb_read,
^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb.c:2997:11: error: incompatible function pointer types initializing 'ssize_t (*)(struct file *, const char *, size_t, loff_t *)' (aka 'long (*)(struct file *, const char *, unsigned long, long long *)') with an expression of type 'ssize_t (struct file *, const u8 *, size_t, loff_t *)' (aka 'long (struct file *, const unsigned char *, unsigned long, long long *)') [-Werror,-Wincompatible-function-pointer-types]
.write =        sisusb_write,
^~~~~~~~~~~~
2 errors generated.

vim +2996 drivers/usb/misc/sisusbvga/sisusb.c

^1da177e4c3f41 Linus Torvalds              2005-04-16  2991  
066202dd48cf32 Luiz Fernando N. Capitulino 2006-08-05  2992  static const struct file_operations usb_sisusb_fops = {
^1da177e4c3f41 Linus Torvalds              2005-04-16  2993  	.owner =	THIS_MODULE,
^1da177e4c3f41 Linus Torvalds              2005-04-16  2994  	.open =		sisusb_open,
^1da177e4c3f41 Linus Torvalds              2005-04-16  2995  	.release =	sisusb_release,
^1da177e4c3f41 Linus Torvalds              2005-04-16 @2996  	.read =		sisusb_read,
^1da177e4c3f41 Linus Torvalds              2005-04-16  2997  	.write =	sisusb_write,
^1da177e4c3f41 Linus Torvalds              2005-04-16  2998  	.llseek =	sisusb_lseek,
022e468e139573 Jiri Slaby                  2019-01-22  2999  #ifdef CONFIG_COMPAT
^1da177e4c3f41 Linus Torvalds              2005-04-16  3000  	.compat_ioctl = sisusb_compat_ioctl,
^1da177e4c3f41 Linus Torvalds              2005-04-16  3001  #endif
49f15255465321 Alan Cox                    2008-05-22  3002  	.unlocked_ioctl = sisusb_ioctl
^1da177e4c3f41 Linus Torvalds              2005-04-16  3003  };
^1da177e4c3f41 Linus Torvalds              2005-04-16  3004  

:::::: The code at line 2996 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux