On 20-05-24 07:40:34, Jun Li wrote:
> Hi
>
> > -----Original Message-----
> > From: Peter Chen <peter.chen@xxxxxxx>
> > Sent: 2020年5月24日 7:23
> > To: balbi@xxxxxxxxxx; mathias.nyman@xxxxxxxxx
> > Cc: linux-usb@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> > pawell@xxxxxxxxxxx; rogerq@xxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; Jun Li
> > <jun.li@xxxxxxx>; Peter Chen <peter.chen@xxxxxxx>
> > Subject: [PATCH v2 7/9] usb: host: xhci-plat: add priv flag for
> > skip_phy_initialization
> >
> > Some DRD controllers (eg, dwc3 & cdns3) have PHY management at their own driver
> > to cover both device and host mode, so add one priv flag for such users to skip
> > PHY management from HCD core.
>
> Can this flag be set directly in __cdns3_host_init()?
No, since both HCD creation and usb_add_hcd invoking are at
xhci_plat_probe, glue layer has no chance to change hcd flags.
Peter
>
> Li Jun
> >
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxx>
> > ---
> > drivers/usb/host/xhci-plat.c | 8 ++++++-- drivers/usb/host/xhci-plat.h | 1 +
> > 2 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index
> > 03d6bbe51919..a3d6cb464186 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -183,6 +183,8 @@ static int xhci_plat_probe(struct platform_device *pdev)
> > struct usb_hcd *hcd;
> > int ret;
> > int irq;
> > + struct xhci_plat_priv *priv = NULL;
> > +
> >
> > if (usb_disabled())
> > return -ENODEV;
> > @@ -280,8 +282,7 @@ static int xhci_plat_probe(struct platform_device *pdev)
> > priv_match = dev_get_platdata(&pdev->dev);
> >
> > if (priv_match) {
> > - struct xhci_plat_priv *priv = hcd_to_xhci_priv(hcd);
> > -
> > + priv = hcd_to_xhci_priv(hcd);
> > /* Just copy data for now */
> > *priv = *priv_match;
> > }
> > @@ -329,6 +330,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
> >
> > hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node);
> > xhci->shared_hcd->tpl_support = hcd->tpl_support;
> > + if (priv && priv->skip_phy_initialization)
> > + hcd->skip_phy_initialization = 1;
> > +
> > ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
> > if (ret)
> > goto disable_usb_phy;
> > diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h index
> > 1fb149d1fbce..8825e8eb28d6 100644
> > --- a/drivers/usb/host/xhci-plat.h
> > +++ b/drivers/usb/host/xhci-plat.h
> > @@ -13,6 +13,7 @@
> > struct xhci_plat_priv {
> > const char *firmware_name;
> > unsigned long long quirks;
> > + unsigned int skip_phy_initialization:1;
> > void (*plat_start)(struct usb_hcd *);
> > int (*init_quirk)(struct usb_hcd *);
> > int (*suspend_quirk)(struct usb_hcd *);
> > --
> > 2.17.1
>
--
Thanks,
Peter Chen
