Re: [PATCH] usb: musb: return -ESHUTDOWN in urb when three-strikes error happened

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Then do you think we should change the API?
> > 
> > Right now it's a little too complicated.  There's no real reason for 
> > EPROTO, EILSEQ, and ETIME to be different codes.  And now you seem to be 
> > suggesting that we should fold them all into ESHUTDOWN.
> 
> I haven't studied all the USB error code enough to suggest this. I am
> only changing to ESHUTDOWN in musb driver because I know this 3-strikes
> error should only be caused by USB device disabled, which is the
> definition of ESHUTDOWN in error-code.rst.

You should spend a little time studying the error-codes document.  
EPROTO, EILSEQ, and ETIME describe different kinds of errors that all 
fall into the 3-strikes category.

Alan Stern



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux