On Thu, May 14, 2020 at 11:52:50AM +0200, Christian Gromm wrote: > @@ -186,13 +185,14 @@ static inline int start_sync_ep(struct usb_device *usb_dev, u16 ep) > * get_stream_frame_size - calculate frame size of current configuration > * @cfg: channel configuration > */ > -static unsigned int get_stream_frame_size(struct most_channel_config *cfg) > +static unsigned int get_stream_frame_size(struct most_channel_config *cfg, > + struct device *dev) I feel like normally "dev" would be the first pointer instead of the second. It goes from permanent --> temporary. Central --> outer. That rule of thumb basically works for this file. regards, dan carpenter
