Hi, > -----Original Message----- > From: Felipe Balbi <balbif@xxxxxxxxx> On Behalf Of Felipe Balbi > Sent: 2020年5月14日 18:51 > To: Jun Li <jun.li@xxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; Peter Chen > <peter.chen@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH] usb: dwc3: allow dual role switch by defautl for new IP w/o > OTG > > > Hi, > > Li Jun <jun.li@xxxxxxx> writes: > > For new IP version DWC3_REVISION_330A or above, current code only > > allows dual role if role-switch is used, those IP w/o OTG only removes > > OTG block but dual role should be capable so don't limit dual role, > > user may use debugfs or any other way to switch role. > > then you need to compile your kernel with support for Dual Role. This patch is the > wrong way to go. I am not sure I catch your point. For dwc3, the change intention is to make the port to be still dual role( don't force dwc->dr_mode to be USB_DR_MODE_PERIPHERAL, but still keep it to be USB_DR_MODE_OTG) in this case. so need compile the kernel with CONFIG_USB_DWC3_DUAL_ROLE enabled is reasonable. Li Jun > > -- > balbi
