Hi, Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> writes: >>> @@ -1223,6 +1231,10 @@ static void dwc3_prepare_trbs(struct dwc3_ep *dep) >>> >>> if (!dwc3_calc_trbs_left(dep)) >>> return; >>> + >>> + /* Don't prepare ahead. This is not an option for DWC_usb32. */ >>> + if (req->request.is_last) >>> + return; >> this requires some better description. Why isn't it an option for dwc_usb32? > > Internally, DWC_usb32 does some advance caching and burst that we should > not prepare more TRB until the transfer is completed. > This doesn't apply for isoc, missed a check here. Need to apply on the > next version. Do you mind re-wording this statement as a comment in the code? -- balbi
Attachment:
signature.asc
Description: PGP signature
