On Sat, May 09, 2020 at 11:02:13AM +0300, Felipe Balbi wrote: > > Hi, > > Andrey Konovalov <andreyknvl@xxxxxxxxxx> writes: > >> here you're changing userspace ABI. Aren't we going to possibly break > >> some existing applications? > > > > Hi Felipe, > > > > I've been working on tests for Raw Gadget for the last few weeks [1], > > which revealed a few problems with the interface. This isn't yet > > included into any released kernel, so my hope that changing the ABI is > > OK during the rc stage. > > Fair enough. If that's okay with Greg, it's okay with me, but then how > do we include it into the -rc seen as it's not really a fix? > > Greg, are you okay with me including such large patches during the -rc? > They essentially add new IOCTLs to the raw-gadget interface. Yes, as the driver only went in for -rc1, it's fine to add fixes like this so late as we don't want to ship a -final with it in broken form. thanks, greg k-h
