Hi, On Thu, May 07, 2020 at 10:47:31PM +0100, Bryan O'Donoghue wrote: > V2: > - Put myself down as sole schema maintainer as suggested - Andy > - Fixed whitespace typo - Andy > - Removed ifdef and of_match_ptr() - Andy > > V1: > This simple series adds DT binding yaml and a DT lookup table for the > tps6598x. > > Its possible to use i2c id_table to match the 'compatible = "ti,tps6598x" > and probe that way, however I think it is worthwhile adding a specific OF > way of doing it and having an accompanying yaml as an example. > > Bryan O'Donoghue (2): > dt-bindings: usb: Add TI tps6598x device tree binding documentation > usb: typec: tps6598x: Add OF probe binding > > .../devicetree/bindings/usb/ti,tps6598x.yaml | 64 +++++++++++++++++++ > drivers/usb/typec/tps6598x.c | 7 ++ > 2 files changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml There was already a series from Angus [1] for this. The bindings looked a bit different, but I think we should use these, because in the DT bindings from Angus there appeared to be definitions for OF graph that was not used. Or maybe I got it wrong? Angus, is it OK if we use these patches instead the ones from you? [1] https://lore.kernel.org/linux-usb/20200506191718.2144752-1-angus@xxxxxxxx/ thanks, -- heikki