Hi Prashant,
On Thu, May 07, 2020 at 03:40:41PM -0700, Prashant Malani wrote:
> > +static int sbu_orientation(struct pmc_usb_port *port)
> > +{
> > + if (port->sbu_orientation)
> > + return port->sbu_orientation - 1;
> > +
> > + return port->orientation - 1;
> > +}
> > +
> > +static int hsl_orientation(struct pmc_usb_port *port)
> > +{
> > + if (port->hsl_orientation)
> > + return port->hsl_orientation - 1;
> > +
> > + return port->orientation - 1;
> > +}
> > +
> > static int pmc_usb_command(struct pmc_usb_port *port, u8 *msg, u32 len)
> > {
> > u8 response[4];
> > @@ -151,8 +170,9 @@ pmc_usb_mux_dp(struct pmc_usb_port *port, struct typec_mux_state *state)
> >
> > req.mode_data = (port->orientation - 1) << PMC_USB_ALTMODE_ORI_SHIFT;
> > req.mode_data |= (port->role - 1) << PMC_USB_ALTMODE_UFP_SHIFT;
> > - req.mode_data |= (port->orientation - 1) << PMC_USB_ALTMODE_ORI_AUX_SHIFT;
> > - req.mode_data |= (port->orientation - 1) << PMC_USB_ALTMODE_ORI_HSL_SHIFT;
> > +
> > + req.mode_data |= sbu_orientation(port) << PMC_USB_ALTMODE_ORI_AUX_SHIFT;
>
> I'm curious to know what would happen when sbu-orientation == "normal".
> That means |port->sbu_orientation| == 1.
>
> It sounds like what should happen is the AUX_SHIFT orientation
> setting should follow what |port->orientation| is, but here it
> looks like it will always be set to |port->sbu_orientation - 1|, i.e 0,
> even if port->orientation == TYPEC_ORIENTATION_REVERSE, i.e 2, meaning
> it should be set to 1 ?
I'll double check this, and get back to you..
Thanks a lot for reviewing this. If you guys have time, then please
check also that the documentation I'm proposing in patch 3/4 for this
driver has everything explained clearly enough, and nothing is missing.
Br,
--
heikki
