On Tue, Apr 28, 2020 at 9:57 PM <mani@xxxxxxxxxx> wrote: > From: Manivannan Sadhasivam <mani@xxxxxxxxxx> > > Add gpiochip support for Maxlinear/Exar USB to serial converter > for controlling the available gpios. > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: linux-gpio@xxxxxxxxxxxxxxx > Signed-off-by: Manivannan Sadhasivam <mani@xxxxxxxxxx> That's a nice and clean GPIO driver. I would change this: port_priv->gc.label = "xr_gpios"; to something that is device-unique, like "xr-gpios-<serial number>" which makes it easy to locate the GPIOs on a specific serial converter for lab use. However the USB serial maintainers know better what to use here. Whatever makes a USB-to-serial unique from a TTY point of view is probably fine with me too. My idea is that people might want to know which USB cable this is sitting on, so I have this USB cable and from this label I can always figure out which GPIO device it is. Either way, it is not a super-big issue so: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Is this a off-the-shelf product that can be bought or is it mainly integrated on boards? I'm asking because I'm looking for a neat USB-to-serial adapter with some GPIOs (2 is enough) that can be used for reset and power cycling of lab boards using one simple piece of equipment. Yours, Linus Walleij
