On Fri, Apr 24, 2020 at 03:16:35PM +0200, Andrey Konovalov wrote: > On Fri, Apr 24, 2020 at 10:43 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > > On Fri, Apr 24, 2020 at 03:09:58AM +0200, Andrey Konovalov wrote: > > > They must return the number of bytes transferred during the data stage. > > > > > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > > > > This was my mistake. Please add a Fixes tag. > > > > Fixes: 068fbff4f860 ("usb: raw-gadget: Fix copy_to/from_user() checks") > > > > I should have seen that bug... I thought I was being careful and I > > even singled out that part of the commit and mentioned it in the > > commit message but I messed up. Sorry. > > No worries, the bug was actually present before your change, but in a > slightly different form. So FWIW we can also add: > > Fixes: f2c2e717642c ("usb: gadget: add raw-gadget interface") > > However raw-gadget is not present in any released kernel yet, so need > of backporting AFAIU. The Fixes: tag lets scripts know that it's not required to back port it. regards, dan carpenter