On Fri, 24 Apr 2020, Qais Yousef wrote: > Follow suit of ohci-platform.c and perform pm_runtime_set_active() on > resume. > > ohci-platform.c had a warning reported due to the missing > pm_runtime_set_active() [1]. > > [1] https://lore.kernel.org/lkml/20200323143857.db5zphxhq4hz3hmd@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > Signed-off-by: Qais Yousef <qais.yousef@xxxxxxx> > CC: Tony Prisk <linux@xxxxxxxxxxxxxxx> > CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > CC: Mathias Nyman <mathias.nyman@xxxxxxxxx> > CC: Oliver Neukum <oneukum@xxxxxxx> > CC: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > CC: linux-usb@xxxxxxxxxxxxxxx > CC: linux-kernel@xxxxxxxxxxxxxxx > --- > > xhci_resume() here could fail, I wasn't sure if we need to call > pm_runtime_set_active() unconditionally. I assumed not. > > There was another function xhci_plat_resume(), I think we just care about the > PM runtime resume callback only. > > Please have a closer look. No, it's the other way around. The function you want to change is the one used for system resume, not runtime resume. Alan Stern
