Re: [PATCH] [RFC] usb: dwc2: Run the core connect in dwc2_hcd_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 4/13/2020 6:54 PM, Marek Vasut wrote:
> On 4/13/20 4:45 PM, Minas Harutyunyan wrote:
>> Hi,
> 
> Hi,
> 
>> On 4/13/2020 6:31 PM, Marek Vasut wrote:
>>> On STM32MP1 without the STUSB1600 USB-C chip (i.e. with plain USB-OTG
>>
>> Could you please provide GSNPSID, GHWCFG1-4 register values for STM32MP1.
> 
> GSNPSID = 0x4f54330a
> GHWCFG1 = 0x00000000
> GHWCFG2 = 0x228fe150
> GHWCFG3 = 0x03b892e8
> GHWCFG4 = 0xe3f00030
> 
STM32MP1 core doesn't support ACG feature: GHWCFG4_ACG_SUPPORTED = 0. 
So, in your patch for STM32MP1 at least these lines are no meaning:

+	/* Enable ACG feature in device mode,if supported */
+	dwc2_enable_acg(hsotg);

Looks like you just copied this chirp from dwc2_conn_id_status_change() 
function.

dwc2_hsotg_core_init_disconnected() function is device mode function, 
not sure that it's safe to call it for host mode in dwc2_hcd_init().

Thanks,
Minas





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux