Re: [PATCH 0/7] Universal Serial Bus: Removing Acronyms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-04-01 at 10:43 -0400, Alan Stern wrote:
> On Wed, 1 Apr 2020, Felipe Balbi wrote:
> 
> > 
> > Hi,
> > 
> > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> > > On Wed, Apr 01, 2020 at 10:32:42AM +0300, Felipe Balbi wrote:
> > >>  764 files changed, 86304 insertions(+), 86304 deletions(-)
> > >
> > > Ah, a nice tiny patchset, I'll try to sneak this in during the merge
> > > window now :)
> > 
> > That's great, Greg. It'll help hundreds of people, I'm sure.
> > 
> > > nice job...
> > 
> > Thank you
> 
> Yes indeed.  Not to mention the admirable side effect of increasing the
> amount of exercise our fingers will get in the future while we write
> patches and new drivers.  And a wonderful example of how a sizable
> _increase_ in the total size of the kernel source can lead to a
> _decrease_ in confusion for readers.
> 
I find that I will spend more time to read/write the code!

e.g.
-static void uhci_unlink_qh(struct uhci_hcd *uhci, struct uhci_qh *qh)
+static void universal_host_controller_interface_unlink_qh(struct
universal_host_controller_interface_hcd
*universal_host_controller_interface, struct
universal_host_controller_interface_qh *qh)


> (Plus this is a great illustration of how consistently violating the
> 80-column rule can be justifiable under the right circumstances.)
> 
> Alan Stern
> 





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux