On 24.03.20 11:20, Johan Hovold wrote: > On Fri, Mar 06, 2020 at 07:00:42PM +0000, Michael Hanselmann wrote: >> Add more #defines with register names. > > Please be more specific (e.g. which registers are you naming). Update > the patch summary too. Done. Will be in the next revision. >> - r = ch341_control_out(dev, CH341_REQ_WRITE_REG, 0x2518, lcr); >> + reg = ((uint16_t)0x2500) | CH341_REG_LCR; > > Ditto, and please add a bit shift for consistency. > > Hmm, but this is unrelated to the defines you are adding, and there are > other magic constants for registers in this driver. Perhaps drop this > bit or break it out in its own patch (rule of thumb: one logical change > per patch). I figured out what the 0x25 register is, or maybe was, and updated the patch with a description and moved it later in the series, just before the simulated break condition. Michael
