On Fri, Mar 27, 2020 at 04:03:50PM +0100, Matthias Reichl wrote:
> commit b401f8c4f492c ("USB: cdc-acm: fix rounding error in TIOCSSERIAL")
> introduced a regression by changing the order of capability and close
> settings change checks. When running with CAP_SYS_ADMIN setting the
> close settings to the values already set resulted in -EOPNOTSUPP.
>
> Fix this by changing the check order back to how it was before.
>
> Fixes: b401f8c4f492c ("USB: cdc-acm: fix rounding error in TIOCSSERIAL")
> Cc: Anthony Mallet <anthony.mallet@xxxxxxx>
> Cc: stable <stable@xxxxxxxxxxxxxxx>
> Cc: Oliver Neukum <oneukum@xxxxxxxx>
> Signed-off-by: Matthias Reichl <hias@xxxxxxxxx>
> ---
> drivers/usb/class/cdc-acm.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Thanks for this, now queued up.
greg k-h
