Hi Michael, On Fri, Mar 06, 2020 at 07:00:41PM +0000, Michael Hanselmann wrote: > A subset of CH341 devices does not support all features, namely the > prescaler is limited to a reduced precision and there is no support for > sending a RS232 break condition. > > These devices can usually be identified by an imprint of "340" on the > turquoise-colored plug. They're also sometimes called "HL340", hence the > terminology in this series and driver. You need to come up with a different designation. I have a HL340 device here which works just fine. > This series adds detection of these devices, adjusts the > divisor/prescaler setup and implements a simulated break condition. > > Michael Hanselmann (4): > ch341: Name more registers > ch341: Detect HL340 variant > ch341: Limit prescaler on HL340 variant > ch341: Simulate break condition on HL340 variant Nit: please use a "USB: serial: ch341:" subject prefix. Also, if possible, please move the second and third patches first in the series as these could be considered fixes rather than new features (and considered for backporting). > drivers/usb/serial/ch341.c | 196 +++++++++++++++++++++++++++++++++---- > 1 file changed, 176 insertions(+), 20 deletions(-) Johan
