Re: [PATCH 0/2] Avoid multiple line dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 20, 2020 at 07:59:06AM +0100, Greg KH wrote:
> On Fri, Mar 20, 2020 at 05:03:03AM +0300, Gokce Kuler wrote:
> > merge a line -> with a line ending with a sign
> > 
> > merge a line -> with a line ending with a sign
> > 
> > Gokce Kuler (2):
> >   staging: rtl8712: Avoid multiple line dereference
> >   staging: rtl8712: Avoid multiple line dereference
> 
> You should put the subsystem and driver in this 0/2 email subject as
> well.
> 
> But the big problem of this (have you been reading other patch
> submissions here?) is that you sent 2 patches that did different things,
> yet had the same subject line, which is not ok.
> 
> Please make them unique.

And why is this 2 patches anyway?  SHouldn't it just be 1 patch as you
are doing 1 logical thing to the file?

Do not make multiple patches were a single one is all that is needed.

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux