Hi Enric, On 3/15/20 4:00 PM, Enrique Vargas wrote: > Make 'Main Picture Path' part of block diagram on separate rows to avoid > 80 chars WARNING found with checkpatch. > > Signed-off-by: Enrique Vargas <jevargas@xxxxxxxxxxxxxx> > --- > drivers/staging/media/rkisp1/rkisp1-dev.c | 57 ++++++++++++++++------- > 1 file changed, 39 insertions(+), 18 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c > index 558126e66465..194fc33941f0 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-dev.c > +++ b/drivers/staging/media/rkisp1/rkisp1-dev.c > @@ -37,26 +37,47 @@ > * > * ISP Block Diagram > * ----------------- > - * rkisp1-resizer.c rkisp1-capture.c > - * |====================| |=======================| > - * rkisp1-isp.c Main Picture Path > - * |==========================| |===============================================| > - * +-----------+ +--+--+--+--+ +--------+ +--------+ +-----------+ > - * | | | | | | | | | | | | | > - * +--------+ |\ | | | | | | | -->| Crop |->| RSZ |------------->| | > - * | MIPI |--->| \ | | | | | | | | | | | | | | > - * +--------+ | | | | |IE|IE|IE|IE| | +--------+ +--------+ | Memory | > - * |MUX|--->| ISP |->|0 |1 |2 |3 |---+ | Interface | > - * +--------+ | | | | | | | | | | +--------+ +--------+ +--------+ | | > - * |Parallel|--->| / | | | | | | | | | | | | | | | | > - * +--------+ |/ | | | | | | | -->| Crop |->| RSZ |->| RGB |->| | > - * | | | | | | | | | | | | Rotate | | | > - * +-----------+ +--+--+--+--+ +--------+ +--------+ +--------+ +-----------+ To be honest, I prefer the old way, I think it is easier to visualize. But lets see what others think. > + * > + * > + * rkisp1-isp.c > + * |==========================| > + * +-----------+ +--+--+--+--+ > + * | | | | | | | > + * +--------+ |\ | | | | | | | > + * | MIPI |--->| \ | | | | | | | > + * +--------+ | | | | |IE|IE|IE|IE| > + * |MUX|--->| ISP |->|0 |1 |2 |3 |--[A]-- > + * +--------+ | | | | | | | | | > + * |Parallel|--->| / | | | | | | | > + * +--------+ |/ | | | | | | | > + * | | | | | | | > + * +-----------+ +--+--+--+--+ You can eliminate the trailing spaces in this patch, since it was generated due to this line break, so you don't need the second patch. Regards, Helen > * ^ > - * +--------+ | |===============================================| > - * | DMA |------------------------------------+ Self Picture Path > + * +--------+ | > + * | DMA |------------------------------------+ > * +--------+ > - * > + * > + * > + * rkisp1-resizer.c rkisp1-capture.c > + * |====================| |=======================| > + * Main Picture Path > + * |===============================================| > + * +--------+ +--------+ +-----------+ > + * | | | | | | > + * -->| Crop |->| RSZ |------------->| | > + * | | | | | | | > + * | +--------+ +--------+ | Memory | > + * --[A]---+ | Interface | > + * | +--------+ +--------+ +--------+ | | > + * | | | | | | | | | > + * -->| Crop |->| RSZ |->| RGB |->| | > + * | | | | | Rotate | | | > + * +--------+ +--------+ +--------+ +-----------+ > + * > + * |===============================================| > + * Self Picture Path > + * > + * > * rkisp1-stats.c rkisp1-params.c > * |===============| |===============| > * +---------------+ +---------------+ >
