On Thu, Mar 12, 2020 at 08:18:07AM -0700, Bart Van Assche wrote: > On 2020-03-12 04:39, Andy Shevchenko wrote: > > There are users in kernel that duplicate {get,put}_unaligned_{l,b}e24() > > implementation. Provide generic helpers once for all. > > Hi Andy, > > Thanks for having done this work. In case you would not yet have noticed > the patch series that I posted some time ago but for which I did not > have the time to continue working on it, please take a look at > https://lore.kernel.org/lkml/20191028200700.213753-1-bvanassche@xxxxxxx/. Can you send a new version? Also, consider to use byteshift to avoid this limitation: "Only use get_unaligned_be24() if reading p - 1 is allowed." -- With Best Regards, Andy Shevchenko