On Thu, Mar 12, 2020 at 03:05:42PM +0100, Christoph Hellwig wrote: > On Thu, Mar 12, 2020 at 01:39:41PM +0200, Andy Shevchenko wrote: > > There are users in kernel that duplicate {get,put}_unaligned_{l,b}e24() > > implementation. Provide generic helpers once for all. > > I have a vague memory of Bart sending a patch like this a while ago, > adding him to verify my theory. Thanks! > Also is there any good to have this in asm-generic/ vs linux/? For now on it is least invasive. asm-generic/unaligned is a cross point for all unaligned accessor helpers, since we here do byteshift approach for all possible variants, I don't see any other header suitable. Or are you talking about something like linux/unaligned/24bit.h -> #include <...> here? -- With Best Regards, Andy Shevchenko