Thanks for the review.
On Thu, Mar 12, 2020 at 1:51 AM Chen-Yu Tsai <wens@xxxxxxxx> wrote:
>
> On Tue, Mar 10, 2020 at 4:43 AM George Hilliard
> <thirtythreeforty@xxxxxxxxx> wrote:
> >
> > The suniv SoC has one USB OTG port connected to a MUSB controller.
> >
> > Add support for its USB PHY.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
>
> Not sure why Icenowy's SoB is here. If she was the original author, you
> are supposed to keep her name as the author.
So, I was unclear on the convention here. This patch is based on her
patch, but I've modified it and rebased those modifications back into
a single change. I'm happy to change the author field - does it need
a "Co-authored-by: myself" here?
> >
> > static const struct of_device_id sun4i_usb_phy_of_match[] = {
> > + { .compatible = "allwinner,suniv-f1c100s-usb-phy",
> > + .data = &suniv_f1c100s_cfg },
> > { .compatible = "allwinner,sun4i-a10-usb-phy", .data = &sun4i_a10_cfg },
>
> Please use the same style (and ignore checkpatch.pl on this one).
Very happy to change this, it was bugging me!
George
