Re: [PATCH v6 0/5] usb: xhci: Add support for Renesas USB controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31-01-20, 10:47, Alan Stern wrote:
> On Thu, 30 Jan 2020, Mathias Nyman wrote:
> 
> > I realize this can't be easily changed because usb_hcd_pci_probe() takes the
> > pci_device_id pointer as an argument, and expects id.driver_data to be a
> > HC driver pointer.
> > 
> > So this turns out to be a question for Greg and Alan:
> > 
> > Would it make sense to change usb_hcd_pci_probe() to take a HC driver pointer
> > as an argument instead of a pointer to pci_device_id?
> > pci_device_id pointer is only used to extract the HC driver handle.
> > This way the driver_data could be used for, well, driver data.
> 
> That seems like a good idea to me.  There aren't very many drivers that 
> use usb_hcd_pci_probe(); changing them all should be fairly easy.

Yup it was easy to do :) I have done this and tested it. Now we can use
driver_data for driver data.

Though couldn't compile the uhci, seems to have missing Makefile entry.

-- 
~Vinod



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux