On 2/20/20 21:39, Stephen Rothwell wrote:
> Hi all,
>
> For some time I have been getting the following warning from the powerpc
> allyesconfig build:
>
> drivers/usb/host/fhci-hcd.c: In function 'fhci_urb_enqueue':
> drivers/usb/host/fhci-hcd.c:398:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 398 | size = 2;
> | ~~~~~^~~
> drivers/usb/host/fhci-hcd.c:399:2: note: here
> 399 | case PIPE_BULK:
> | ^~~~
>
> Introduced by commit
>
> 236dd4d18f29 ("USB: Driver for Freescale QUICC Engine USB Host Controller")
>
> from 2009, but exposed only recently.
>
Thanks for the report, Stephen. The following patch should fix that:
https://lore.kernel.org/lkml/20200213085401.27862-1-linux@xxxxxxxxxxxxxxxxxx/
Greg,
I would just replace the two "Fixes" tags in the patch above with this one:
Fixes: 236dd4d18f29 ("USB: Driver for Freescale QUICC Engine USB Host Controller")
Thanks
--
Gustavo
