Re: [PATCH 096/143] USB: gadget: add USB Audio Gadget driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 19, 2009 at 11:04:59AM -0700, David Brownell wrote:
> On Friday 19 June 2009, Greg KH wrote:
> > > > +#define AUDIO_VENDOR_NUM               0x0525  /* NetChip */
> > > > +#define AUDIO_PRODUCT_NUM              0xa4a1  /* Linux-USB Audio Gadget */
> > > > +
> > > 
> > > You may not use that product number; it's already been allocated.
> > > A simple grep in that directory shows that:
> > > 
> > > ether.c:#define CDC_PRODUCT_NUM               0xa4a1  /* Linux-USB Ethernet Gadget */
> > > 
> > > Likewise looking at the usb.ids file.
> > > 
> > > If you like, you may use 0xa4ab ...
> > 
> > Hm, we should really use the vendor id reserved for Linux here, and
> > assign a product id from our own pool, instead of wasting NetChip's
> > pool.
> 
> In this case it's from *my* pool, delegated to me by NetChip.  :)

Heh, good point :)

> > I'll assign the next one that I have free, unless someone objects?
> 
> That's OK by me.

Good, I'll go do that.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux