On Fri, Feb 14, 2020 at 10:15:57AM -0800, Joe Perches wrote: > Make structs const to reduce data size ~20KB. > > Change function arguments and prototypes as necessary to compile. > > $ size (x86-64 defconfig pre) > text data bss dec hex filename > 12281 10948 480 23709 5c9d ./drivers/usb/storage/usb.o > 111 10528 8 10647 2997 ./drivers/usb/storage/usual-tables.o > > $ size (x86-64 defconfig post) > text data bss dec hex filename > 22809 420 480 23709 5c9d drivers/usb/storage/usb.o > 10551 0 0 10551 2937 drivers/usb/storage/usual-tables.o > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > --- > > compile tested only > > drivers/usb/storage/usb.c | 10 +++++----- > drivers/usb/storage/usb.h | 5 +++-- > drivers/usb/storage/usual-tables.c | 6 +++--- > include/linux/usb_usual.h | 2 +- > 4 files changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c > index 9a79cd..94a6472 100644 > --- a/drivers/usb/storage/usb.c > +++ b/drivers/usb/storage/usb.c > @@ -121,12 +121,12 @@ MODULE_PARM_DESC(quirks, "supplemental list of > device IDs and their quirks"); > .initFunction = init_function, \ > } > > -static struct us_unusual_dev us_unusual_dev_list[] = { > +static const struct us_unusual_dev us_unusual_dev_list[] = { > # include "unusual_devs.h" > { } /* Terminating entry */ > }; > > -static struct us_unusual_dev for_dynamic_ids = > +static const struct us_unusual_dev for_dynamic_ids = > USUAL_DEV(USB_SC_SCSI, USB_PR_BULK); > > #undef UNUSUAL_DEV > @@ -583,7 +583,7 @@ EXPORT_SYMBOL_GPL(usb_stor_adjust_quirks); > > /* Get the unusual_devs entries and the string descriptors */ > static int get_device_info(struct us_data *us, const struct > usb_device_id *id, Patch is line-wrapped and does not apply at all :(