On Sat, Feb 08, 2020 at 04:50:22PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Variable num is being assigned with a value that is never read, it is > assigned a new value later in a for-loop. The assignment is redundant > and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/usb/typec/ucsi/ucsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c > index d5a6aac86327..b1b72cb7af10 100644 > --- a/drivers/usb/typec/ucsi/ucsi.c > +++ b/drivers/usb/typec/ucsi/ucsi.c > @@ -400,7 +400,7 @@ static int ucsi_register_altmodes(struct ucsi_connector *con, u8 recipient) > struct typec_altmode_desc desc; > struct ucsi_altmode alt[2]; > u64 command; > - int num = 1; > + int num; > int ret; > int len; > int j; Greg! I'll pick this, and to you with a few other patches that I have in my queue for the ucsi driver. I hope that's OK. thanks, -- heikki