On Wed, Feb 12, 2020 at 09:41:12AM +0000, Vladimir Stankovic wrote: > On 11.2.20. 17:39, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > On Tue, Feb 11, 2020 at 04:21:24PM +0000, Vladimir Stankovic wrote: > >> 39 files changed, 8668 insertions(+) > > > > This is a bit hard, if not impossible, to review all in one huge patch. > > > > Can you resend this as a patch series, breaking it down into logical > > chunks, like all other kernel patches have? > > > > Also, why so many individual files? For only 8k lines, 39 files seems > > like a huge number. > > > > thanks, > > > > greg k-h > > > Will break it down into patch series and resend. > > In regards of the file count, our intention was to ease the > troubleshooting efforts during development and have a clear separation > between logical parts of MA-USB implementation (i.e data in/out, isoch > in/out, etc.; each source file representing logical chunk). Yeah, but at the very least, only have a single .h "internal" file, you have whole files for just 1 or 2 function prototypes, that's totally overkill. Simple is good, you don't want to have to bounce around through multiple files for a simple 8k line driver, that's not a good idea. thanks, greg k-h
