Hi Bryan, On Fri, Feb 07, 2020 at 08:16:45PM +0000, Bryan O'Donoghue wrote: > This patch adds a routine to find a usb-conn-gpio in the main DWC3 code. > This will be useful in a subsequent patch where we will reuse the current > extcon VBUS notifier with usb-conn-gpio. > > --- > drivers/usb/dwc3/dwc3-qcom.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 261af9e38ddd..fc66ca3316ef 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -550,6 +550,21 @@ static const struct dwc3_acpi_pdata sdm845_acpi_pdata = { > .ss_phy_irq_index = 2 > }; > > +static bool dwc3_qcom_find_gpio_usb_connector(struct platform_device *pdev) Why not just squash this patch into "[PATCH v5 12/18] usb: dwc3: qcom: Enable gpio-usb-conn based role-switching" where it is actually used? Jack -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project