Hi Pavel, Could you change the patch title to something like this (see other patches changing the device-trees, you'll see it's the common pattern): ARM: dts: bcm283x: increase dwc2's RX FIFO size On Fri, 2020-02-07 at 17:30 +0100, Pavel Hofman wrote: > The previous version of the dwc2 overlay set the RX FIFO size to > 256 4-byte words. This sounds large enough for a 1024 byte packet (the > largest isochronous high speed packet allowed), but it doesn't take > into account some extra space needed by the hardware. > > Minas Harutyunyan at Synopsys (the source of the DWC OTG design) > came up with a more correct value, 301, but since there is spare packet > RAM this can be increased to 558 to allow two packets per frame. I suggest making a short summary of your github explanation[1] instead of just citing Minas. On one hand Minas' memory might get fuzzy after some time (or not be able to access the documentation) and... > See: https://github.com/raspberrypi/linux/issues/3447 ...you're assuming this link will be always available. Which is unlikely. After properly explaining the issue, you won't need the link anyway. Ultimately a patch description should be as self-contained/self-explanatory as possible. Other than that the patch looks good. Thanks! Nicolas [1] https://github.com/raspberrypi/linux/issues/3447#issuecomment-581815066
Attachment:
signature.asc
Description: This is a digitally signed message part
