Re: [PATCH] usb: chipidea: tegra: fix hardlock with invalid dr mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



27.01.2020 18:25, Peter Geis пишет:
> On Mon, Jan 27, 2020 at 2:18 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>>
>> On Sun, Jan 26, 2020 at 09:35:48PM -0500, Peter Geis wrote:
>>> The ci_hdrc_tegra driver does not currently support dual role mode, but
>>> it does not explicitly prevent its use.
>>> Certain devices support dual role mode, but not automatic role switch.
>>> This can cause the device to lock up during initialization of the
>>> driver.
>>>
>>> Detect this state by checking for the extcon phandle when dual role mode
>>> is set to otg.
>>> If it doesn't exist request the driver to only enable manual role
>>> switching.
>>>
>>> Fixes: dfebb5f ("usb: chipidea: Add support for Tegra20/30/114/124")
>>
>> Please use 12 digits for kernel sha1 values, this should be:
>> Fixes: dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124")
> 
> Understood, thank you.
> I will ensure that is the case in the future.

Please also take a look at the kernel's scripts/checkpatch.pl, running
'scripts/checkpatch.pl --strict path_to.patch' will help to catch such
things.



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux