Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Thursday, January 23, 2020 10:34 PM <snip> > > --- a/drivers/usb/host/ehci-platform.c > > +++ b/drivers/usb/host/ehci-platform.c > > > +static const struct soc_device_attribute quirk_poll_match[] = { > > + { .soc_id = "r8a7795" }, > > + { .soc_id = "r8a77951" }, > > As .soc_id is derived from the main compatible value, it is "r8a7795" for both > R-Car H3 ES1.x (R8A77950) and ES2.0+ (R8A77951). Oh, I got it. > > + { .soc_id = "r8a7796" }, > > + { .soc_id = "r8a77961" }, > > + { .soc_id = "r8a77965" }, > > + { .soc_id = "r8a77990" }, > > + { .soc_id = "r8a77995" }, > > Instead of matching on .soc_id, you can also match on .family = "R-Car Gen3" > (until we discover a future family member that is not affected?). Thank you for this suggestion. I'll use such a .family (until then). > I guess this affects RZ/G2, too? .family = "RZ/G2". I think so. So, I'll add "RZ/G2" on v3 patch. Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds