Hi Geert-san, > From: Geert Uytterhoeven, Sent: Thursday, January 23, 2020 5:57 PM <snip> > > I'm trying to add some undocumented compatible values, but it seems hard > > to add because: > > - Some dts[i] files have undocumented compatible strings. > > # We can find it by using the following command: > > # $ grep "generic-ehci" `find -name "*.dts*"` | grep "," > > > > - I tried to use "oneOf:" and "contains:" combination, but it failed. > > > > - This generic-ehci.yaml uses "contains:" for the compatible now. > > So, even if compatible property has undocumented compatible string, > > make dtbs_check command succeeded (except node names). > > Probably you'll have to write a separate DT binding doc file for R-Car Gen3, > referring to generic-ehci.yaml using $ref. I see. > > - In my opinion, almost all user (excect R-Car SoCs) doesn't needs > > specific compatible values, so that adding such compatible values > > causes less usability in the future. > > > > So, I suspended adding specific compatible values and I'll use > > soc_device_match() for this workaround for now... > > Which has the advantage that it will enable the quirk with old DTBs, too ;-) I think so :) Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds