Joe Perches [mailto:joe@xxxxxxxxxxx] > Sent: Tuesday, January 21, 2020 9:01 PM > To: David Miller; Hayes Wang [...] > > > static int rtl8153_enable(struct r8152 *tp) > > > { > > > + u32 ocp_data; > > > if (test_bit(RTL8152_UNPLUG, &tp->flags)) > > > return -ENODEV; > > > > > > > Please put an empty line after the local variable declarations. > > Local scoping is generally better. > > Perhaps declare ocp_data inside the if branch > where it's used. OK. I would move it. Best Regards, Hayes
