On Sun, Jan 19, 2020 at 03:48:32PM +0100, Steve Markgraf wrote: > Hi Johan, > > On 19.01.20 14:58, Johan Hovold wrote: > > I just took a quick look at the libosmo-fl2k code and it appears that > > you claim both interfaces but never set alternate setting 1 for > > interface 0, which would enable those endpoints. > > > > Could you see if that's all that's needed to get your application > > working again? > > Yes, you are right, I had another look at it today and tried exactly > that, and it's working now with altsetting 1 of interface 0. > I will push a change to osmo-fl2k shortly. That's good to hear, thanks for confirming. > There is also an out-of-tree kernel driver that makes use of this > device, and might even need interface 1, but I haven't verified this so > far: > > https://github.com/FrescoLogic/FL2000 I'm afraid we don't care much about out-of-tree kernel drivers. > The question is if there are other devices out there where there are > duplicate endpoints on different interfaces. The spec clearly states > that this is forbidden, but the USBx0CV Chapter 9 tests do not test for > this and pass just fine, so I assume the FL2000 will not be the only > device in the market where this mistake has been made. That's a valid concern, but the problem is that USB core cannot really handle such devices currently. If we get a flood of reports about this we may have to reconsider how best to deal with them however. Johan
