On Wed, Jan 15, 2020 at 11:44:14AM +0000, Minas Harutyunyan wrote: > On 1/15/2020 3:30 PM, Lukas Wunner wrote: > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_linux-2Dusb_77c07f00a6a9d94323c4a060a3c72817b0703b97.1574244795.git.lukas-40wunner.de_&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=6z9Al9FrHR_ZqbbtSAsD16pvOL2S3XHxQnSzq8kusyI&m=RvUQvVjq5dj9CVUu3njmpdm88GS6B3rFv7iB9Rj8k4Y&s=p4AmQK1vx63kNa3BDdfxaOO1C80AvmgTQY5wtKJcXbc&e= > > Actually I agree with you on unnecessary unlock/lock here. Currently I'm > going to test your patch before Ack. > Just, want to check with you - did you see any issue in driver flow > without this patch? or it just code cleanup? Just a cleanup. I was looking through dwc_otg (which is still used by the Raspberry Pi Foundation's downstream tree) and checked to what extent the antipatterns found there are still present in dwc2, thereby found this occurrence. Thanks, Lukas
