NAK this patch.
> + for (i = 0; i < urb->actual_length; i++, ch++) {
> + if (!usb_serial_handle_sysrq_char(port, *ch))
> + tty_insert_flip_char(tty, *ch, TTY_NORMAL);
Sorry but this is unacceptable. Some of the USB 3G modems and similar are
running bytes through the USB serial layer at about 3MBits and this is an
obscene pile of function calls thrown directly into the fast path.
Matching a byte pattern also has security impacts because I can send that
byte pattern and you currently have to recompile to turn the sysrq stuff
around.
At the very least before this patch is acceptable you need to inline the
port->sysrq check
And in future please Cc me on tty layer patches Jason (if this one was
Cc'd and never made it here I apologise).
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
