> On Jan 15, 2020, at 4:33 AM, Mario.Limonciello@xxxxxxxx wrote: > > > >> -----Original Message----- >> From: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> >> Sent: Monday, January 13, 2020 10:41 PM >> To: davem@xxxxxxxxxxxxx; hayeswang@xxxxxxxxxxx >> Cc: Kai-Heng Feng; Jakub Kicinski; Prashant Malani; Grant Grundler; Limonciello, >> Mario; Chen7, David; open list:USB NETWORKING DRIVERS; open list:NETWORKING >> DRIVERS; open list >> Subject: [PATCH] r8152: Add MAC passthrough support to new device >> >> >> [EXTERNAL EMAIL] >> >> Device 0xa387 also supports MAC passthrough, therefore add it to the >> whitelst. > > Have you confirmed whether this product ID is unique to the products that > support this feature or if it's also re-used in other products? This is unique for Lenovo product. > > For Dell's devices there are very specific tests that make sure that this > feature only applies on the products it is supposed to and nothing else > (For example RTL8153-AD checks variant as well as effuse value) > (Example two: RTL8153-BND is a Dell only part). Hayes, do you know how macpassthru on Lenovo dock works? Kai-Heng > >> >> BugLink: https://bugs.launchpad.net/bugs/1827961/comments/30 >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> >> --- >> drivers/net/usb/r8152.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c >> index c5ebf35d2488..42dcf1442cc0 100644 >> --- a/drivers/net/usb/r8152.c >> +++ b/drivers/net/usb/r8152.c >> @@ -6657,7 +6657,8 @@ static int rtl8152_probe(struct usb_interface *intf, >> } >> >> if (le16_to_cpu(udev->descriptor.idVendor) == VENDOR_ID_LENOVO && >> - le16_to_cpu(udev->descriptor.idProduct) == 0x3082) >> + (le16_to_cpu(udev->descriptor.idProduct) == 0x3082 || >> + le16_to_cpu(udev->descriptor.idProduct) == 0xa387)) >> set_bit(LENOVO_MACPASSTHRU, &tp->flags); >> >> if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 && udev->serial >> && >> -- >> 2.17.1 >
