On Tue, 14 Jan 2020, Leizhen (ThunderTown) wrote: > Does no one pay attention to this problem? Although there is no > functional problem, but it seems confusing. > > if (!list->hiddev->exist) { <--------- > res = -ENODEV; | > goto bail_unlock; | > } | > if (!list->hiddev->open++) | > if (list->hiddev->exist) { <--------- //It's always true. This code no longer exists after refactoring that happened in commit 18a1b06e5b91d47. -- Jiri Kosina SUSE Labs