On Mon, Jan 13, 2020 at 09:25:28AM +0000, Peter Chen wrote: > On 20-01-11 17:56:06, Fabio Estevam wrote: > > Hi Peter, > > > > On Thu, Jan 9, 2020 at 7:55 AM Peter Chen <peter.chen@xxxxxxx> wrote: > > > > > +static const struct of_device_id cdns_imx_of_match[] = { > > > + { .compatible = "fsl,imx8qm-usb3", }, > > > > Please also send a separate patch for documenting this compatible string. > > I had wanted to add it, but the working version is based on some > other basic dts patches, eg clock changes, which has still not > in mainline, so some properties in the example at this dt binding > file may not be found at mainline kernel, is it ok? No, sorry, that does not work, please get the dts patch in as well. thanks, greg k-h