On Thu, Jan 9, 2020 at 3:30 AM Hanjie Lin <hanjie.lin@xxxxxxxxxxx> wrote: [...] > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: xtal_usb_phy the "usb_phy" part of "xtal_usb_phy" seems redundant to me: it's the XTAL clock input (this is what I'd expect as clock-name) of the USB PHY (this is already part of the node name). in addition to keeping the reset-names consistent (as Neil suggested) please also use the same clock-names as G12 Thank you! Martin